This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix weight templates for cargo doc check#11505
Closed
ggwpez wants to merge 6 commits intoshawntabrizi-bench-scriptfrom
Closed
Fix weight templates for cargo doc check#11505ggwpez wants to merge 6 commits intoshawntabrizi-bench-scriptfrom
cargo doc check#11505ggwpez wants to merge 6 commits intoshawntabrizi-bench-scriptfrom
Conversation
* InMemoryBackend: Make it generic over the key hasher * Update primitives/state-machine/src/in_memory_backend.rs Co-authored-by: cheme <emericchevalier.pro@gmail.com> * Update primitives/state-machine/src/in_memory_backend.rs Co-authored-by: cheme <emericchevalier.pro@gmail.com> * FMT Co-authored-by: cheme <emericchevalier.pro@gmail.com>
* Unify rpc api and implementation name Signed-off-by: koushiro <koushiro.cqx@gmail.com> * MauanlSeal ==> ManualSealRpc Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Remove extra Rpc naming in the structs Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update doc Signed-off-by: koushiro <koushiro.cqx@gmail.com> * fix merge Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
…few bugs (#11461) * cli: fix RPC CLI nits * remove needless lines * cargo fmt * Update client/service/src/lib.rs Co-authored-by: James Wilson <james@jsdw.me> Co-authored-by: James Wilson <james@jsdw.me>
If `--validator` is passed we also listen on this address and as `--dev` is a shortcut for multiple CLI args, including `--validator`, we should make it consistent.
* enable signed migrations in benchmarks * T instead of Test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove 'mut' Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A2-insubstantial
ggwpez
changed the title
cargo doc checkcargo doc check
shawntabrizi
approved these changes
May 23, 2022
shawntabrizi
requested review from
acatangiu,
andresilva and
athei
as code owners
Member
|
superseded by fb03b54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc check in #11493 fails since it treats
[NS]as link 🤦♂️Fixed by not using abbreviations.